-
Notifications
You must be signed in to change notification settings - Fork 42
grpc-native: Pre-Built gRPC library to avoid long compilation times #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
approved these changes
Aug 27, 2025
Member
Mr3zee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mr3zee
pushed a commit
that referenced
this pull request
Oct 27, 2025
…461) * grpc-native: Build cache, not working Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Build cache within repository Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Add gRPC includes Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Cleanup Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Small fixes Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Use header sources from dependency instead of copy (bazel) Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Extract headers on demand Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Remove copy of include directory Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Remove unnecessary source dir * grpc-native: Address PR comments --------- Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Nov 12, 2025
…461) * grpc-native: Build cache, not working Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Build cache within repository Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Add gRPC includes Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Cleanup Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Small fixes Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Use header sources from dependency instead of copy (bazel) Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Extract headers on demand Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Remove copy of include directory Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Remove unnecessary source dir * grpc-native: Address PR comments --------- Signed-off-by: Johannes Zottele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC/Native, project setup
Problem Description
Before this, the gRPC core library was compiled from source when loading the gradle project.
With multiple targets this took at least 10 minutes.
Solution
We are now including gRPC as a pre-built static library, so it is not required to build it from source.
We also tried to use a remote repository for this, but we faced several issues.